acks are not congestion control -> be careful #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR is a clarification based on the discussion in issue #454. Of course it's optimal to add this recommendation or not. However, it's in the implementation considerations section and I think at least noting the issue is a good thing.
mirjak
requested review from
huitema,
Yanmei-Liu and
qdeconinck
and removed request for
huitema and
Yanmei-Liu
huitema
reviewed
Dec 24, 2024
mirjak
commented
Jan 10, 2025
Yanmei-Liu
reviewed
Jan 13, 2025
qdeconinck
reviewed
Jan 13, 2025
huitema
approved these changes
Jan 13, 2025
Yanmei-Liu
approved these changes
Jan 15, 2025
mirjak
commented
Jan 17, 2025
@qdeconinck the implementation section is currently 4.5 pages. It has a bunch of subsections but most of them are short. I think that is fine and I think we should more concentrate to have all the other sections concise and to the point. However, again, I'm planning to do a full editorial pass and I can imagine that some alignment in the implementation section might also make that part a bit shorter. Therefore I think we should merge for now. |
qdeconinck
approved these changes
Jan 17, 2025
Co-authored-by: Yanmei Liu <[email protected]>
mirjak
commented
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is a clarification based on the discussion in issue #454. Of course it's optimal to add this recommendation or not. However, it's in the implementation considerations section and I think at least noting the issue is a good thing.